Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MixedBooleanOperatorSniff #3205

Closed
wants to merge 2 commits into from

Conversation

TimWolla
Copy link

@TimWolla TimWolla commented Feb 2, 2021

Hi 👋

This is my first contribution to PHP CodeSniffer. This PR adds a sniff that detects mixed boolean operators (&&, ||) within a single expression without making precedence clear using parentheses.

I hope I did not miss an existing sniff that already does what I want this sniff to do. Please also let me know if I violated any written or unwritten rules regarding the namespace structure, code formatting, commit messages, etc or if you think I missed some edge case within my unit test.

@TimWolla TimWolla marked this pull request as draft February 2, 2021 16:03
@TimWolla TimWolla marked this pull request as ready for review February 2, 2021 16:15
@TimWolla
Copy link
Author

I was going through the list of my open PRs:

I'm seeing that this PR was assigned to a project / to the idea bank. How will this process further? I don't plan on making any more changes, unless you see issues during review.

@gsherwood
Copy link
Member

Sorry this hasn't moved. I've been prioritising bug fixes and support for newer PHP versions so I haven't looked into this yet.

@TimWolla

This comment has been minimized.

@TimWolla

This comment was marked as outdated.

@jrfnl
Copy link
Contributor

jrfnl commented Feb 16, 2024

FYI: this new sniff is included in today's PHP_CodeSniffer 3.9.0 release.

As per #3932, development on PHP_CodeSniffer will continue in the PHPCSStandards/PHP_CodeSniffer repository. If you want to stay informed, you may want to start "watching" that repo (or watching releases from that repo).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Ready for Release
Development

Successfully merging this pull request may close these issues.

3 participants